Skip to content

Handle multiple mouse event types in common.rs #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sje397 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle multiple mouse event types in common.rs #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/macos/common.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ pub unsafe fn convert(
event => Some(EventType::ButtonRelease(Button::Unknown(event as u8))),
}
}
CGEventType::MouseMoved => {
CGEventType::MouseMoved | CGEventType::LeftMouseDragged | CGEventType::RightMouseDragged | CGEventType::OtherMouseDragged => {
Copy link

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new behavior of treating drag events as mouse move events lacks test coverage. Consider adding tests that verify LeftMouseDragged, RightMouseDragged, and OtherMouseDragged events are correctly converted to EventType::MouseMove, similar to the existing MouseMove tests in tests/listen_and_simulate.rs.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The event mask kCGEventMaskForAllEvents is missing OtherMouseDragged. While this line correctly handles OtherMouseDragged events in the conversion logic, these events will never be received because they're not registered in the event mask. Add + (1 << CGEventType::OtherMouseDragged as u64) after line 71 in the event mask definition to ensure these events are captured.

Copilot uses AI. Check for mistakes.
let point = cg_event.location();
Some(EventType::MouseMove {
x: point.x,
Expand Down