Fix SyncAction causing mods to load resources too early #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever we patch methods for `SyncAction`, it would cause any non-vanilla types to attempt to load their static data. This caused them to load resources like graphics, which failed and caused issues with those mods. I've fixed it by delaying patching of any non-vanilla methods whose declaring types have `StaticConstructorOnStartup` attribute on them. I've decided to let unaffected methods be patched early in case patching those early was by design due to anything I may be unaware of. Currently, this should fix issues with Moving Bases from Vanilla Expanded Framework.
SokyranTheDragon
added
fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever we patch methods for
SyncAction, it would cause any non-vanilla types to attempt to load their static data. This caused them to load resources like graphics, which failed and caused issues with those mods.I've fixed it by delaying patching of any non-vanilla methods whose declaring types have
StaticConstructorOnStartupattribute on them.I've decided to let unaffected methods be patched early in case patching those early was by design due to anything I may be unaware of.
Currently, this should fix issues with Moving Bases from Vanilla Expanded Framework.