-
-
Notifications
You must be signed in to change notification settings - Fork 125
Welcome window #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Welcome window #688
Conversation
|
Now requires rwmt/Multiplayer-Locale#33 |
|
I appreciate the initiative but I have concerns about integrating this information directly into the mod. The information displayed on the message can change anytime, the prepatcher mod can disappear, the issues listed can be fixed. It feels like extra information prone to become outdated that needs mainteinance and an annoyance the average user will just skip. The right place for this is the project's download or documentation page. I'm open to merging if there's team consensus, but my recommendation is to avoid a hard-coded solution. |
|
Thanks for checking this! I understand your concern at a hardcoded solution, and I actually agree that this info belongs on the workshop page. I think a built-in window is more likely to effectively convey this sort of information than the workshop page because it interrupts the user before they start. There is a button to never show the information again (until the version number is updated in the translation) so it won’t bother users every time if they don’t want it to. The window could be used quite effectively as a changelog with a few minor changes, which I’d be happy to implement, and it is not unheard of (I believe Allow Tool has a one-time changelog window). — This is actually now quite dynamic. I forgot to mention it before when I said “Now requires rwmt/Multiplayer-Locale#33 ”: It can be easily updated by adding/removing The workshop page would have to be updated every time there’s an update which only a limited number of people can do. With this, anyone who proposes a fix can also update the translations. I do understand there are a lot of translations though, and updating all of them could get quite tedious. |
Shows a welcome
Dialog_MessageBoxthe first time you open the multiplayer tab each time you run the game. If you press "Never show again" it will not show the message box until the next update.The message is hard-coded (not translatable). Each known issue is an element in an array.