Skip to content

Conversation

@TreadTheDawnGames
Copy link

image

Shows a welcome Dialog_MessageBox the first time you open the multiplayer tab each time you run the game. If you press "Never show again" it will not show the message box until the next update.

The message is hard-coded (not translatable). Each known issue is an element in an array.

@TreadTheDawnGames TreadTheDawnGames marked this pull request as ready for review September 16, 2025 18:10
@notfood notfood added enhancement New feature or request. 1.6 Fixes or bugs relating to 1.6 (Not Odyssey). labels Sep 17, 2025
@notfood notfood moved this to In review in 1.6 and Odyssey Sep 17, 2025
@TreadTheDawnGames
Copy link
Author

Now requires rwmt/Multiplayer-Locale#33

@notfood
Copy link
Member

notfood commented Sep 27, 2025

I appreciate the initiative but I have concerns about integrating this information directly into the mod.

The information displayed on the message can change anytime, the prepatcher mod can disappear, the issues listed can be fixed. It feels like extra information prone to become outdated that needs mainteinance and an annoyance the average user will just skip. The right place for this is the project's download or documentation page.

I'm open to merging if there's team consensus, but my recommendation is to avoid a hard-coded solution.

@TreadTheDawnGames
Copy link
Author

Thanks for checking this!

I understand your concern at a hardcoded solution, and I actually agree that this info belongs on the workshop page.

I think a built-in window is more likely to effectively convey this sort of information than the workshop page because it interrupts the user before they start. There is a button to never show the information again (until the version number is updated in the translation) so it won’t bother users every time if they don’t want it to.

The window could be used quite effectively as a changelog with a few minor changes, which I’d be happy to implement, and it is not unheard of (I believe Allow Tool has a one-time changelog window).

This is actually now quite dynamic. I forgot to mention it before when I said “Now requires rwmt/Multiplayer-Locale#33 ”:

It can be easily updated by adding/removing <KnownIssue[.*]>Issue Description</KnownIssue[.*]> translation tags to the translation XMLs (as seen here) whenever a fix to any given issue is proposed. It is able to handle an arbitrary number of KnownIssue tags, and they need not be numbered.

The workshop page would have to be updated every time there’s an update which only a limited number of people can do. With this, anyone who proposes a fix can also update the translations. I do understand there are a lot of translations though, and updating all of them could get quite tedious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.6 Fixes or bugs relating to 1.6 (Not Odyssey). enhancement New feature or request.

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

2 participants