Fix duplicate text in download button #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
問題: - LocalizationManagerでボタンのテキストを更新する際、HTML内の改行や空白のテキストノードに翻訳テキストを設定してしまい、元のテキストが残って重複表示される問題があった 解決方法: - 新しいupdateButtonTextヘルパーメソッドを追加 - すべてのテキストノードを削除してから新しいテキストを追加する方式に統一 - SVGアイコンなどの要素がある場合、その後にテキストを配置 影響範囲: - updateTextToFileTab - updateRemoveZerosTab - updateBlendShapeTab
s4na
deleted the
claude/fix-duplicate-button-text-011CUrC5TE6wcA4oC7q1uZu4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
問題:
解決方法:
影響範囲: