feat!: Use ref borrowing for config #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks, and the delimiter string is currently unused. I don't think keeping it on the stack will be that crucial to performance but time will tell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API in the latest version changed which requires cloning config because it takes the owned version which makes no sense. Let's just use borrowing and avoid unnecessay cloning.
The other questoin about the string for delimiters: does the API need it to be a string? Should it be configurable at compile time. E.g. to take the const N: usize generic and have the stored as [char; N]? Or it is also possible to use SmallVec to make this struct stack allocated again