Skip to content

Conversation

@santisq
Copy link
Owner

@santisq santisq commented Sep 10, 2025

Should fix #16. Would you be willing to review @poshAJ or @CrookedJ 😬 ?

@santisq santisq self-assigned this Sep 10, 2025
@santisq santisq linked an issue Sep 10, 2025 that may be closed by this pull request
@santisq santisq added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Sep 10, 2025
@santisq santisq requested a review from CrookedJ September 12, 2025 13:48
@CrookedJ
Copy link
Collaborator

Group has 861 members, 242 of which are groups

Measure-Command {
  $group = Get-ADGroup 'Group'
  $group, $group, $group | Get-ADTreeGroupMember -Recursive
} | Select -Exp TotalMilliseconds

Averages across 5 runs

Total Milliseconds PSADTree 1.1.5 PSADTree 1.1.6
Pwsh 7.5.2 8747 3173
WinPS 5.1 8972 3130

@santisq santisq requested a review from poshAJ September 17, 2025 15:08
Copy link
Collaborator

@poshAJ poshAJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment, but LGTM.

@santisq
Copy link
Owner Author

santisq commented Sep 29, 2025

Perf tests in a really small environment...

PS C:\Users\Administrator\Documents\pwsh\PSADTree> .\tests\perf-1.1.6.ps1

Test                     Average (5 invocations) RelativeSpeed
----                     ----------------------- -------------
PSADTree v1.1.6-pwsh-7   00:00:11.175            1x
PSADTree v1.1.6-pwsh-5.1 00:00:21.677            1.94x
PSADTree v1.1.5-pwsh-7   00:00:30.029            2.69x
PSADTree v1.1.5-pwsh-5.1 00:00:41.761            3.74x

@santisq santisq merged commit c24f4f7 into main Sep 29, 2025
4 checks passed
@santisq santisq deleted the 16-cross-store-reference-resolution-error branch September 29, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cross-store reference resolution error

4 participants