Skip to content

Conversation

@jfiga
Copy link

@jfiga jfiga commented Jan 12, 2026

Summary of Uncommitted Changes (git diff)

Uncommitted changes in 2 files:

1- gtime/cli.py — Sorting feature for favorites list
Changes to print_favorites() function:

  • Added sorting by UTC offset: cities are sorted in descending order (highest offset first)
  • Unknown offsets (UTC?) are placed at the end
  • Implementation:
    • Collects city data with offset values before adding to table
    • Sorts by total_minutes (UTC offset in minutes)
    • Adds rows to the table in sorted order

Impact: The favorites list now displays cities ordered by timezone offset instead of the original order.

2- tests/test_comprehensive_city_search.py — Test function renaming
Function renames (6 functions):

  • test_city_searches() → run_city_searches()
  • test_country_searches() → run_country_searches()
  • test_fuzzy_searches() → run_fuzzy_searches()
  • test_case_sensitivity() → run_case_sensitivity()
  • test_suggestions() → run_suggestions()

Updated calls in main() to use the new names.
Reason: Likely to prevent pytest from treating these as test cases (they appear to be helper/runner functions).

Summary

  • Feature: UTC offset sorting in favorites display
  • Refactor: Test function renaming for better test organization
  • Status: Uncommitted (not staged or committed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant