-
Notifications
You must be signed in to change notification settings - Fork 95
Make std::jthread support conditional based on C++ 201911L
#651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@sbooth would love this ;) |
|
@sbooth so you didnt go that route? how are you going to fix the build? |
|
I don't think that there is anything wrong with the build that needs to be fixed in |
|
@sbooth but it wont build on intel mac using xcode 16. It is just one version below :( Forcing people to use xcode 26 is pretty tough. Not even sure i can install xcode 26 on intel |
|
I'm sure whether Xcode 26 is a tough requirement could be debated either way, but Xcode 26 does work on Intel Macs. I have an older Intel model and I'm using Xcode 26 with no issues. The only restriction I know of is that the visionOS SDK requires an ARM processor. |
|
@sbooth still pretty sad to see you force people to use xcode 26. Never seen a library do that kind of "requirement". |
|
I'll reopen this PR for further consideration. |
This is a draft PR to address uncertain availability of
std::jthreadin Apple clang.