Skip to content

Add userInfo to AVAE configuration change notification #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sbooth wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add userInfo to AVAE configuration change notification #692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2291d2
Add `userInfo` to AVAE configuration change notification
sbooth Dec 29, 2025
8b4dec7
Merge branch 'main' into userinfo
sbooth Dec 29, 2025
1bc1123
Merge branch 'main' into userinfo
sbooth Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/CSFBAudioEngine/Player/AudioPlayer.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1874,8 +1874,8 @@ bool PerformSeekIfRequired() noexcept
}
}

if([player_.delegate respondsToSelector:@selector(audioPlayerAVAudioEngineConfigurationChange:)])
[player_.delegate audioPlayerAVAudioEngineConfigurationChange:player_];
if([player_.delegate respondsToSelector:@selector(audioPlayer:audioEngineConfigurationChange:)])
[player_.delegate audioPlayer:player_ audioEngineConfigurationChange:userInfo];
}

#if TARGET_OS_IPHONE
Expand Down
3 changes: 2 additions & 1 deletion Sources/CSFBAudioEngine/include/SFBAudioEngine/SFBAudioPlayer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,8 @@ NS_SWIFT_NAME(AudioPlayer.Delegate) @protocol SFBAudioPlayerDelegate <NSObject>
/// Called to notify the delegate when the configuration of the `AVAudioEngine` changes
/// - note: Use this instead of listening for `AVAudioEngineConfigurationChangeNotification`
/// - parameter audioPlayer: The `SFBAudioPlayer` object
- (void)audioPlayerAVAudioEngineConfigurationChange:(SFBAudioPlayer *)audioPlayer NS_SWIFT_NAME(audioPlayerAVAudioEngineConfigurationChange(_:));
/// - parameter userInfo: The `userInfo` object from the notification
- (void)audioPlayer:(SFBAudioPlayer *)audioPlayer audioEngineConfigurationChange:(nullable NSDictionary *)userInfo;
/// Called to notify the delegate when an asynchronous error occurs
/// - parameter audioPlayer: The `SFBAudioPlayer` object
/// - parameter error: The error
Expand Down