Skip to content

Conversation

@ycexiao
Copy link
Contributor

@ycexiao ycexiao commented Jun 30, 2025

What problem does this PR address?

Closes #30.

What should the reviewer(s) do?

Please check the modifications.

  • This PR introduces a public-facing change (e.g., figures, CLI input/output, API).
    • Documentation (e.g., tutorials, examples, README) has been updated.
    • A tracking issue or plan to update documentation exists.
  • This PR affects internal functionality only (no user-facing change).

@ycexiao
Copy link
Contributor Author

ycexiao commented Jun 30, 2025

@sbillinge @sbillinge, it's ready for review.

@sbillinge
Copy link
Contributor

LGTM. I guess there are no typo's and it works correctly? Pleaes could you show screenshots of an example first time through (default defaults) and second time through (project defaults) and that it doesn't crash or anything bad happen second time through? Then I can merge.

@ycexiao
Copy link
Contributor Author

ycexiao commented Jul 1, 2025

@sbillinge
Running package create system in a directory without cookiecutter.json
image

Change the path to a-different-package-name. cookiecutter.json is created. package create system uses the new default values in the directory
image

@bobleesj
Copy link
Collaborator

bobleesj commented Jul 1, 2025

@ycexiao Looks good to me!

@sbillinge sbillinge merged commit d310978 into scikit-package:main Jul 2, 2025
2 checks passed
@ycexiao ycexiao mentioned this pull request Jul 3, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add project-level cookiecutter.json in {{ cookiecutter.github_repo_name }}

3 participants