Add Python 3 compatibility #362
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
There was a problem hiding this comment.
Oof. I think this is a sign that I need to convert over to something like requests.
Owner
|
I know I said it on the pysteam pull request as well, but thanks for doing this. I'll try to take a look sometime soon. The big thing I need to solve before I merge this is I need to figure out how to make sure I dont break it as soon as I write another line of code :P. |
Contributor
Author
|
Agreed, making sure the compatibility works in Pysteam is the first step. I saw some work had gone into this before as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim is to allow running in either Python 2 or 3. Still some things missing:
return sum(map(self.roms_for_console, consoles), [])inrom_finder.pysincemap()now returns an iteratorif not instancesinsettings.pyin Python 3 actually works onmap()iteratorsWould appreciate some testing, et al.