Feat/server matrix notification #54
Conversation
Thank you for the pull request! 💙The Scribe-Server team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
add test workflow fix branch name change process add main update secrets fix secret update workflow fix script update test text test script flow change dump file host test flow reopen flow update secrets update data add scribe bot access token update dump date and time remove test file
DeleMike
force-pushed
the
feat/server-matrix-notification
branch
from
22f2ff6 to
9b260d9
Compare
|
Hi @andrewtavis , I have a PR up to send update_scribe_data.yml workflow results to the Data channel. The last stage is to have Scribe-bot in my Space and see it in action in the test room. I requested an invite from the Scribe bot, if it is possible. Once I see how it behaves in my room via the workflow, then I can be certain of this PR. But I have already added its configs, so I expect it to work well regardless. Here is a sample result we are sending. What do you think? ✅ Toolforge Server Update Successful
See a typical result |
update_data.sh
Outdated
| # Auto-confirm the download prompt with "y" for the initial confirmation. | ||
| echo "y" | scribe-data download -wdv latest || { | ||
| # scribe-data download -wdv latest | ||
| echo "y" | scribe-data download -wdv 20251210 || { |
There was a problem hiding this comment.
question: This should be switched back to latest, right? I think we're also planning on not using dumps for the data updates at this time, so we should switch this for the command that runs the queries for the given languages?
There was a problem hiding this comment.
okay, I will have to correct it. The dump website at the time was having bad data dump so it could not be parsed.
I will test and see if it works now.
There was a problem hiding this comment.
I have tested the command scribe-data download -wdv latest, locally, and the latest-lexemes.json is valid now. I will revert.
|
@andrewtavis I have reverted it. Can you review please? |
andrewtavis
left a comment
andrewtavis
left a comment
There was a problem hiding this comment.
praise: All's looking great here, @DeleMike 😊 Thank you so much for the work here to have this process visible to the community 💙🩵
3 participants
Contributor checklist
./pre-commitexecutable as well asmake lintand have fixed all reported issuesDescription
A PR to send update_scribe_data.yml workflow results to the Data channel.
Related issue