Skip to content

Conversation

@catreedle
Copy link
Collaborator

@catreedle catreedle commented Jan 2, 2026

Contributor checklist


Description

  • Add DownloadDataScreen with Update section
  • Edit InstallationVC to include navigation to DownloadDataScreen

Related issue

@github-actions
Copy link

github-actions bot commented Jan 2, 2026

Thank you for the pull request! 💙

The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and iOS rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link

github-actions bot commented Jan 2, 2026

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the CI unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

@catreedle, would you be able to resolve the merge conflicts for this PR?

@andrewtavis andrewtavis self-requested a review January 3, 2026 16:14
@catreedle
Copy link
Collaborator Author

@catreedle, would you be able to resolve the merge conflicts for this PR?

sure.. working on it

@catreedle catreedle force-pushed the download-screen-swift branch from 1e692c1 to 752033f Compare January 5, 2026 09:00
@andrewtavis
Copy link
Member

Looks like there are some more merge conflicts after bringing in #565 :) Would you be able to fix these, @catreedle?

@andrewtavis
Copy link
Member

Really appreciate you getting to these issues!

@catreedle
Copy link
Collaborator Author

Looks like there are some more merge conflicts after bringing in #565 :) Would you be able to fix these, @catreedle?

sure!

@andrewtavis
Copy link
Member

Updated the PR description text such that we just have - Closes #566 once, @catreedle :) We don't need to repeat it, but just add Closes into the template when the PR closes an issue :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Amazing work here, @catreedle! So great to see this screen up and running after so long 😊 Really thanks so much :) :)

@andrewtavis andrewtavis merged commit c41c52d into scribe-org:main Jan 6, 2026
3 checks passed
@catreedle
Copy link
Collaborator Author

praise: Amazing work here, @catreedle! So great to see this screen up and running after so long 😊 Really thanks so much :) :)

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add base data download UI

2 participants