-
Notifications
You must be signed in to change notification settings - Fork 103
Download screen swift #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for the pull request! 💙The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
|
@catreedle, would you be able to resolve the merge conflicts for this PR? |
sure.. working on it |
1e692c1 to
752033f
Compare
|
Looks like there are some more merge conflicts after bringing in #565 :) Would you be able to fix these, @catreedle? |
|
Really appreciate you getting to these issues! |
sure! |
|
Updated the PR description text such that we just have |
andrewtavis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: Amazing work here, @catreedle! So great to see this screen up and running after so long 😊 Really thanks so much :) :)
Thank you! :) |
Contributor checklist
xcodebuildandswiftlint --strictcommands as directed in the testing section of the contributing guideDescription
Related issue