Skip to content

Conversation

@prince-0408
Copy link
Contributor

Fixes #573

This PR prevents a crash in Settings when the Indonesian keyboard is installed by safely handling missing language abbreviations.

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

Thank you for the pull request! 💙

The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and iOS rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the CI unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Thanks for the PR, @prince-0408! I think that the best thing to do for now is to disable the Indonesian keyboard as has been done with Danish and Norwegian. We can enable it when we start working on it again 😊

CC @catreedle for the change here 👋

@andrewtavis andrewtavis merged commit fb9297b into scribe-org:main Jan 4, 2026
3 checks passed
catreedle pushed a commit to catreedle/Scribe-iOS that referenced this pull request Jan 5, 2026
…rg#574)

* Fix crash in Settings when Indonesian keyboard is installed

* Remove Indonesian from keyboards for now - WIP

---------

Co-authored-by: Andrew Tavis McAllister <andrew.t.mcallister@gmail.com>
catreedle pushed a commit to catreedle/Scribe-iOS that referenced this pull request Jan 5, 2026
…rg#574)

* Fix crash in Settings when Indonesian keyboard is installed

* Remove Indonesian from keyboards for now - WIP

---------

Co-authored-by: Andrew Tavis McAllister <andrew.t.mcallister@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash in Settings with Indonesian keyboard installed — Fatal error: Abbreviation not found for language: Indonesian

2 participants