Skip to content

Conversation

@catreedle
Copy link
Collaborator

Contributor checklist


Description

Fix i18n keys word for word deletion and description in Scribe/SettingsTab/SettingsTableData.swift

Related issue

  • #ISSUE_NUMBER

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Thank you for the pull request! 💙

The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and iOS rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the CI unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

@catreedle, it's currently looking like this :) Would we want to allow the menu label to be split to the next line? Might be a good idea in case other languages are longer than English.

Simulator Screenshot - iPhone 16e - 2026-01-06 at 00 19 52

@catreedle
Copy link
Collaborator Author

Simulator Screenshot - iPhone 16e - 2026-01-06 at 13 45 58

hi @andrewtavis I tried fixing this and had to increase the row height in general. Hope it's okay.

@andrewtavis andrewtavis self-requested a review January 6, 2026 09:43
@andrewtavis
Copy link
Member

The change for the radio button looks really good, @catreedle, but would we be able to reduce the spacing if there's a sub menu? See below:

Simulator Screenshot - iPhone 16e - 2026-01-06 at 10 46 56

I think it'd be great if we could reduce the above distance by half 🤔

@catreedle
Copy link
Collaborator Author

The change for the radio button looks really good, @catreedle, but would we be able to reduce the spacing if there's a sub menu? See below:

Simulator Screenshot - iPhone 16e - 2026-01-06 at 10 46 56 I think it'd be great if we could reduce the above distance by half 🤔

I will look into it 😊

@andrewtavis
Copy link
Member

Also @catreedle, note that the most recent merged PR updated Scribe-i18n on main :) Just so you're aware that there have been edits. The change was for the About menu option that leads to the website. The Scribe key icon was too short, so I decided to switch it to a globe and the text to "Visit the Scribe website", which has since been updated in Scribe-i18n 🌐

@catreedle
Copy link
Collaborator Author

Also @catreedle, note that the most recent merged PR updated Scribe-i18n on main :) Just so you're aware that there have been edits. The change was for the About menu option that leads to the website. The Scribe key icon was too short, so I decided to switch it to a globe and the text to "Visit the Scribe website", which has since been updated in Scribe-i18n 🌐

noted. thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants