Skip to content

Fix: basefold verify failure #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kunxian-xia wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Fix: basefold verify failure #1165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
cfff75e
add ecc
darth-cy Nov 19, 2025
6d6c4b8
add gkr section
darth-cy Nov 19, 2025
4bdebaa
add gkr section
darth-cy Nov 20, 2025
6ee3a2b
fix selector
darth-cy Nov 20, 2025
396acd3
fix selector
darth-cy Nov 20, 2025
1846a86
fmt
darth-cy Nov 20, 2025
ae2dd31
clippy
darth-cy Nov 20, 2025
05d44b1
keep unit tests
darth-cy Nov 20, 2025
590b7c5
Remove debug flag
darth-cy Nov 20, 2025
a0ce0be
Merge branch 'master' into feat/recursion_ecc
darth-cy Nov 20, 2025
e4e4037
Add ecc arithmetics
darth-cy Nov 23, 2025
a85aad8
ecc arithmetics
darth-cy Nov 23, 2025
03ad436
ignore test
darth-cy Nov 24, 2025
4cc787c
Correct assertions
darth-cy Nov 24, 2025
bfedf5f
Correct assertions
darth-cy Nov 24, 2025
ac93404
Merge branch 'master' into feat/recursion_ecc
darth-cy Nov 25, 2025
4697e12
update bin compilation name
darth-cy Nov 25, 2025
48113d7
cargo dependency
darth-cy Nov 25, 2025
672693c
Complete rewriting aggregation with new dependency
darth-cy Nov 27, 2025
0bce2db
fmt
darth-cy Nov 27, 2025
57fcee8
Localize OpenVM dependency for debug
darth-cy Nov 30, 2025
21b5e85
Finish PI operations
darth-cy Nov 30, 2025
e731d61
Remove debug flags
darth-cy Nov 30, 2025
3551d25
Migrating to new v1.4.1 dependency with native sumcheck
darth-cy Dec 1, 2025
6bff857
Add back u16 adaptor
darth-cy Dec 1, 2025
a326718
Feat: use openvm gpu prover for recursion (#1158)
kunxian-xia Dec 1, 2025
2c299a8
openvm-cuda-backend is optional
kunxian-xia Dec 1, 2025
b446799
Recover internal recursion
darth-cy Dec 1, 2025
a22757c
Add debug flags
darth-cy Dec 1, 2025
284465a
enable tower verify
kunxian-xia Dec 2, 2025
172c019
Merge remote-tracking branch 'origin/feat/recursion_pi' into fix/base…
kunxian-xia Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
438 changes: 282 additions & 156 deletions Cargo.lock
View file
Open in desktop

Large diffs are not rendered by default.

39 changes: 39 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,33 @@ uint = "0.8"
ceno_gpu = { path = "utils/cuda_hal", package = "cuda_hal" }
cudarc = { version = "0.17.3", features = ["driver", "cuda-version-from-build-system"] }

# ceno-recursion dependencies
openvm = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/v1.4.1-scroll-ext", default-features = false }
openvm-circuit = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/v1.4.1-scroll-ext", default-features = false }
openvm-continuations = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/v1.4.1-scroll-ext", default-features = false }
openvm-instructions = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/v1.4.1-scroll-ext", default-features = false }
openvm-native-circuit = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/v1.4.1-scroll-ext", default-features = false }
openvm-native-compiler = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/v1.4.1-scroll-ext", default-features = false }
openvm-native-compiler-derive = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/v1.4.1-scroll-ext", default-features = false }
openvm-native-recursion = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/v1.4.1-scroll-ext", default-features = false }
openvm-rv32im-circuit = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/v1.4.1-scroll-ext", default-features = false }
openvm-sdk = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/v1.4.1-scroll-ext", default-features = false }

# openvm = { path = "../openvm-scroll-tech/crates/toolchain/openvm", default-features = false }
# openvm-circuit = { path = "../openvm-scroll-tech/crates/vm", default-features = false }
# openvm-continuations = { path = "../openvm-scroll-tech/crates/continuations", default-features = false }
# openvm-instructions = { path = "../openvm-scroll-tech/crates/toolchain/instructions", default-features = false }
# openvm-native-circuit = { path = "../openvm-scroll-tech/extensions/native/circuit", default-features = false }
# openvm-native-compiler = { path = "../openvm-scroll-tech/extensions/native/compiler", default-features = false }
# openvm-native-compiler-derive = { path = "../openvm-scroll-tech/extensions/native/compiler/derive", default-features = false }
# openvm-native-recursion = { path = "../openvm-scroll-tech/extensions/native/recursion", default-features = false }
# openvm-rv32im-circuit = { path = "../openvm-scroll-tech/extensions/rv32im/circuit", default-features = false }
# openvm-sdk = { path = "../openvm-scroll-tech/crates/sdk", default-features = false }

openvm-stark-backend = { git = "https://github.com/openvm-org/stark-backend.git", tag = "v1.2.1", default-features = false }
openvm-stark-sdk = { git = "https://github.com/openvm-org/stark-backend.git", tag = "v1.2.1", default-features = false }
openvm-cuda-backend = { git = "https://github.com/openvm-org/stark-backend.git", tag = "v1.2.1", default-features = false }

[profile.dev]
lto = "thin"
# We are running our tests with optimizations turned on to make them faster.
Expand Down Expand Up @@ -114,3 +141,15 @@ lto = "thin"
#transcript = { path = "../gkr-backend/crates/transcript", package = "transcript" }
#whir = { path = "../gkr-backend/crates/whir", package = "whir" }
#witness = { path = "../gkr-backend/crates/witness", package = "witness" }

# [patch."https://github.com/scroll-tech/openvm.git"]
# openvm = { path = "../openvm-scroll-tech/crates/toolchain/openvm", default-features = false }
# openvm-circuit = { path = "../openvm-scroll-tech/crates/vm", default-features = false }
# openvm-continuations = { path = "../openvm-scroll-tech/crates/continuations", default-features = false }
# openvm-instructions = { path = "../openvm-scroll-tech/crates/toolchain/instructions", default-features = false }
# openvm-native-circuit = { path = "../openvm-scroll-tech/extensions/native/circuit", default-features = false }
# openvm-native-compiler = { path = "../openvm-scroll-tech/extensions/native/compiler", default-features = false }
# openvm-native-compiler-derive = { path = "../openvm-scroll-tech/extensions/native/compiler/derive", default-features = false }
# openvm-native-recursion = { path = "../openvm-scroll-tech/extensions/native/recursion", default-features = false }
# openvm-rv32im-circuit = { path = "../openvm-scroll-tech/extensions/rv32im/circuit", default-features = false }
# openvm-sdk = { path = "../openvm-scroll-tech/crates/sdk", default-features = false }
45 changes: 20 additions & 25 deletions ceno_recursion/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,35 +33,30 @@ tracing-subscriber.workspace = true
transcript.workspace = true
whir.workspace = true
witness.workspace = true
openvm.workspace = true
openvm-circuit.workspace = true
openvm-continuations.workspace = true
openvm-instructions.workspace = true
openvm-native-circuit.workspace = true
openvm-native-compiler.workspace = true
openvm-native-compiler-derive.workspace = true
openvm-native-recursion.workspace = true
openvm-rv32im-circuit.workspace = true
openvm-sdk.workspace = true
openvm-stark-sdk.workspace = true
openvm-stark-backend.workspace = true
openvm-cuda-backend = { workspace = true, optional = true }

# openvm
openvm = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/ceno_leaves", default-features = false }
openvm-circuit = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/ceno_leaves", default-features = false, features = ["bench-metrics"] }
openvm-continuations = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/ceno_leaves", default-features = false }
openvm-native-circuit = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/ceno_leaves", default-features = false }
openvm-native-compiler = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/ceno_leaves", default-features = false }
openvm-native-compiler-derive = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/ceno_leaves", default-features = false }
openvm-native-recursion = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/ceno_leaves", default-features = false }
openvm-rv32im-circuit = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/ceno_leaves", default-features = false }
openvm-sdk = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/ceno_leaves", default-features = false }

# openvm = { path = "../../openvm-scroll-tech/crates/toolchain/openvm", default-features = false }
# openvm-circuit = { path = "../../openvm-scroll-tech/crates/vm", default-features = false, features = ["bench-metrics"] }
# openvm-native-circuit = { path = "../../openvm-scroll-tech/extensions/native/circuit", default-features = false }
# openvm-sdk = { path = "../../openvm-scroll-tech/crates/sdk", default-features = false }
# openvm-native-compiler = { path = "../../openvm-scroll-tech/extensions/native/compiler", default-features = false }
# openvm-native-compiler-derive = { path = "../../openvm-scroll-tech/extensions/native/compiler/derive", default-features = false }
# openvm-native-recursion = { path = "../../openvm-scroll-tech/extensions/native/recursion", default-features = false }
# openvm-continuations = { path = "../../openvm-scroll-tech/crates/continuations", default-features = false }
# openvm-rv32im-circuit = { path = "../../openvm-scroll-tech/extensions/rv32im/circuit", default-features = false }

openvm-stark-backend = { git = "https://github.com/openvm-org/stark-backend.git", tag = "v1.1.1", default-features = false }
openvm-stark-sdk = { git = "https://github.com/openvm-org/stark-backend.git", tag = "v1.1.1", default-features = false }
p3-monty-31 = { git = "https://github.com/Plonky3/Plonky3.git", rev = "539bbc84085efb609f4f62cb03cf49588388abdb" }

[[bin]]
name = "e2e_aggregate"
path = "src/bin/e2e_aggregate.rs"

[features]
bench-metrics = ["openvm-circuit/bench-metrics"]
default = ["parallel", "nightly-features"]
bench-metrics = ["openvm-circuit/metrics"]
default = ["parallel", "nightly-features", "openvm-circuit/metrics"]
gpu = ["openvm-circuit/cuda", "openvm-native-circuit/cuda", "dep:openvm-cuda-backend"]
nightly-features = [
"ceno_zkvm/nightly-features",
"openvm-stark-sdk/nightly-features",
Expand Down
Loading
Loading