-
Notifications
You must be signed in to change notification settings - Fork 9
Media kit #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for jade-cajeta-1bcca0 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds a media kit page to the scverse website by introducing logo assets and updating navigation elements to link to the new page.
Key Changes:
- Added logo image assets in SVG and PNG formats (scverse logos and library-specific logos)
- Updated header navigation to include "Media kit" link in the About dropdown
- Updated footer navigation to include "Media kit" link in the Pages section
Reviewed Changes
Copilot reviewed 5 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| static/img/logo/scverse_symbol.svg | SVG version of scverse symbol logo |
| static/img/logo/scverse_symbol.png | PNG version of scverse symbol logo |
| static/img/logo/scverse.svg | Full scverse logo with text in SVG format |
| static/img/logo/scverse.png | Full scverse logo with text in PNG format |
| static/img/libs/spatialdata_horizontal.png | Library logo asset for spatialdata |
| static/img/libs/muon.png | Library logo asset for muon |
| layouts/partials/header.html | Added "Media kit" link to About dropdown menu |
| layouts/partials/footer.html | Added "Media kit" link to footer Pages section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
for more information, see https://pre-commit.ci
|
Thanks for adding this :)
|
|
A more general question is if we should get rid of the gradients from slide templates/examples. I think they have been critizied by multiple people. |
|
Thanks for checking the PR, @grst and @flying-sheep!
I added the version with ®️ to use in legal contexts. In general though, I don't think we should use it as a default option.
I think it's freely available.
I added it for scirpy for now. More generally, some work is needed across packages to make sure both versions exist and are available as svg files but I don't want to make that blocking.
I took a look at it, and it seems svgs for different versions (®, with text, icon only) still need this fix to be incorporated. This is true in general and not just about the media kit. I would put it in the same bucket as the logo improvements for the packages. And thanks again for fixing it! |

This is the first draft for the media kit page.
Please share any major feedback you might have, and let's merge it and iterate on it!