Add support for NumPy 2.4.0 #498
Conversation
frances-h
requested review from
amontanez24,
gsheni and
pvk-developer
and removed request for
a team and
gsheni
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #498 +/- ##
=======================================
Coverage 90.13% 90.13%
=======================================
Files 29 29
Lines 1824 1824
=======================================
Hits 1644 1644
Misses 180 180
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amontanez24
left a comment
amontanez24
left a comment
There was a problem hiding this comment.
tests seem to be failing
amontanez24
left a comment
amontanez24
left a comment
There was a problem hiding this comment.
we do this in SDV to handle the indirect dependencies
https://github.com/sdv-dev/SDV/blob/ad8e4e09bdd01338ea94a60cddd1f06c815273aa/tasks.py#L16
.github/workflows/minimum.yml
Outdated
| run: | | ||
| python -m pip install --upgrade pip | ||
| python -m pip install invoke .[test] | ||
| python -m pip install "scikit-learn<1.8.0" |
There was a problem hiding this comment.
why is this not a requirement?
There was a problem hiding this comment.
Scikit-learn is an optional dependency for the tutorials. 1.8.0 recently released and no longer supports older versions of scipy and numpy which is why the minimum tests were originally failing.
Resolve #497