-
Notifications
You must be signed in to change notification settings - Fork 99
One Click Install Alpha #5178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/2026.01
Are you sure you want to change the base?
One Click Install Alpha #5178
Conversation
Note: Updates don't quite work yet.
|
Tested on build Second Life Project One-click 26.1.0.20387239236 Test plan provided to QA:
I verified on Windows machine that the build installs with one click to [user]/AppData/Local and after install the viewer launches and runs successfully. Viewer is installed Second Life Project One-Click I verified that the app can be removed in the add/remove apps section and the viewer is deleted and leaves behind a SecondLifeProjectOne-Click folder in [user]/AppData/Local containing just 2 files .dead and velopack (log?) I verified you could successfully relaunch the app from the desktop icon and from the App list on the start menu. I verified the Mac build installs on Mac the same way current release viewer does successfully Issues noticed in testing.
So in the spirit of wanting to get the one click install to get user feedback this seems to be meet those goals but the issues should be identified in the release notes to help out the users trying it out. Passed QA based on test plan provided and goals of this release. |
|
Per discussion with grumpity, to make a good first impression with this the updater issues should be addressed before release. |
|
|
||
| static const wchar_t* PROTOCOL_SECONDLIFE = L"secondlife"; | ||
| static const wchar_t* PROTOCOL_GRID_INFO = L"x-grid-location-info"; | ||
| static const wchar_t* VIEWER_EXE_NAME = L"SecondLifeViewer.exe"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This to me seems unnecessary to hardcode the viewer exe name when it can be obtained from gDirUtilp->getExecutableFilename() and then use ll_convert<std::wstring>, since LLDir_Win32 will have been constructed already before WINMAIN has been called.
This would allow for better compatibility with TPV's so they don't all need to change this hardcoded constant to work with Velopack.
For sanity sake, I tested with my development build of Firestorm and after it ran the Velopack installer, inside on_after_install using gDirUtilp->getExecutableFilename() returned the correct exe name, the viewer worked correctly and the installer setup the shortcuts and protocols correctly too.
relnotes:
One Click Install Alpha Viewer
Welcome! The One Click Install Alpha Viewer is an early alpha release to streamline the experience of setting up the viewer on Windows computers and getting in world.
At present, you will have two viewers installed: the one click viewer and the current viewer. This is expected.