Update LLScriptEditor and friends to index line numbers from 1 when editing in Lua #5190
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to match server-generated runtime errors that reference lines. Signed-off-by: Darl <me@darl.cat>
…l expectations Existing behavior for LSL is preserved Fixes a bug in previous commit that causes the line number shown near the bottom of the script edit floater to be off by 1 when displaying a Lua script. Signed-off-by: Darl <me@darl.cat>
DarlCat
changed the title
Signed-off-by: Darl <me@darl.cat>
akleshchev
approved these changes
Dec 31, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The errors generated by SLua on the server reference line numbers starting from 1, not 0. This PR updates the script editor to start numbering lines at 1 when the language is Lua, LSL is unchanged by this PR and continues numbering starting from 0.
Screenshots
Lua error showing matching line number
LSL editing is unchanged
Showing both at the same time
Showing dynamic update when changing compiler dropdown
Screen.Recording.2025-12-29.at.12.49.39.PM.mov
Checklist
Please ensure the following before requesting review: