fixes for linux build #5192
Merged
fixes for linux build #5192
+3
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewMeadows
commented
Dec 30, 2025
| static const type_enum_t LLCORE = 2; ///< mStatus is an HE_* error code | ||
| static constexpr type_enum_t EXT_CURL_EASY = 0; ///< mStatus is an error from a curl_easy_*() call | ||
| static constexpr type_enum_t EXT_CURL_MULTI = 1; ///< mStatus is an error from a curl_multi_*() call | ||
| static constexpr type_enum_t LLCORE = 2; ///< mStatus is an HE_* error code |
Collaborator
Author
There was a problem hiding this comment.
g++-11.4.0 requires these member variables to be constexpr.
akleshchev
approved these changes
Dec 31, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides some fixes for compile errors I encountered when building develop-linux branch on my System76 laptop (Pop!OS, g++-11.4.0, cmake-4.2.1). This PR provides the changes I had to make to convince the viewer to build.