a few bug fixes and tweaks for the new(er) Redis version and Suricata 8. … #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Socket Control mode still not working in Suri 8 because the Python libs are no longer installed with Suricata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Redis lrem() arguments changed with a newer version of Redis and needed to be accounted for.
Suricata as of the latest version (8) no longer includes the expected Python module that Dalton used to interact with Suricata socket control. This adds better error handling for Suricata socket control and cleanly falls back to the traditional method when Suricata socket control is not available.
Suricata socket control still not working (for Dalton) with Suricata 8 but may be fixed in a subsequent PR.