Fixed the extract_pfx function #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my case it would error out due to errors related to OpenSSL: Certificate extraction mixed the certificate and private key into one file (the certificate file should only contain the cert). Errors were hidden, so failures went unnoticed. The SSL library couldn't parse the mixed/corrupted PEM format, causing the "PEM lib" error. Fix: Switched to Python's cryptography library to extract the certificate and key separately and write correctly formatted PEM files. The issue was also mentioned here: secureworks#6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my case it would error out due to errors related to OpenSSL:
Certificate extraction mixed the certificate and private key into one file (the certificate file should only contain the cert). Errors were hidden, so failures went unnoticed.
The SSL library couldn't parse the mixed/corrupted PEM format, causing the "PEM lib" error. Fix:
Switched to Python's cryptography library to extract the certificate and key separately and write correctly formatted PEM files.
The issue was also mentioned here:
#6