Skip to content

Added support for setting template_data on create/update template #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jemeric wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Added support for setting template_data on create/update template #31

jemeric wants to merge 29 commits into from

Conversation

@jemeric
Copy link

@jemeric jemeric commented Jun 6, 2025 •
edited
Loading

Description

Add support for template_data optional fields for template operations

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

jemeric added 22 commits May 29, 2025 17:28
@jemeric
Wired up template_data for client
c442e79
@jemeric
Reverted unintentional changes
84372e1
@jemeric
Fixed a couple more accidental changes
74d1802
@jemeric
Trying dynamically created log for tests
7b2714a
@jemeric
Updating .net version
da7e3f0
@jemeric
Update appveyor image
e00138b
@jemeric
Try again with updated framework target
f17441b
@jemeric
Added Nuget config to try to fix appveyor issues
dfa338f
@jemeric
Try adding missing dependency for appveyor
3088522
@jemeric
Another attempt at fixing expired logs tests
1c7427b
@jemeric
Switched void to Task for appropriate async syntax
4f91a6a
@jemeric
Debugging invalid log id
8a000d1
@jemeric
Upgrade NUnit to wait on async setup
caae8da
@jemeric
Added short wait before running tests
aa24cd3
@jemeric
Trying again using OneTimeSetup to fix synchronousity issues
614eed1
@jemeric
Trying Onetimesetup for API tests to see if it resolves other failures
04a676f
@jemeric
Another attempt to force the setup to run synchronously
df13f4a
@jemeric
Trying again with 1 second delay
e66d158
@jemeric
A bit of cleanup
7991de2
@jemeric
Clean up extra spacing
cef4b47
@jemeric
Bumped the log check delay
ebd57b4
@jemeric
Going back to 1 second timeout since it seemed sufficient
a0883d6
@jemeric jemeric requested a review from a team as a code owner June 6, 2025 00:57
@jemeric jemeric changed the title An 88919984186 template data support Added support for setting template_data on create/update template Jun 6, 2025
@jemeric jemeric closed this Jun 6, 2025
@jemeric jemeric reopened this Jun 6, 2025
@demoore
Mark fixtures as NonParallelizable
0ddf730 
This might be worth moving to XUnit for.
@demoore
Retry logic for tests.
6262f94 
Since logs take a bit before being available on the API a retry should make
this eventually work.
@demoore
Remove Log validation from batch tests
7d1bc5d 
The logs endpoint can be slow, making this test flakey. We don't actually need
to validate that the request was successful, just that the count was correct,
so I'm removing them.
@demoore
Update retry logic for log tests
b561891 
Retries for the log tests should only go for about a minute before failing.
Previously they were set to run indefinitely.
@demoore
Update Newtonsoft.Json
60788b6
@demoore
Standardize test versions. Add macro for NET461
9b0cfa5 
The timeout amount had to be slightly different to work in .net framework since
timings are different across the versions of .net.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jemeric @demoore