Skip to content

Conversation

@cmutel
Copy link
Contributor

@cmutel cmutel commented Sep 27, 2024

No description provided.

@cmutel cmutel requested a review from jsvgoncalves September 27, 2024 06:23
@cmutel
Copy link
Contributor Author

cmutel commented Sep 27, 2024

@janfeitkenhauer

@cmutel
Copy link
Contributor Author

cmutel commented Sep 27, 2024

Should provide the same response format as the new /units, but that code isn't committed so I can't be sure 😸

Comment on lines +119 to +120
# Sorry this is shit but I lost 30 mins fighting with groupby
# and am too burned out to find a better way...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we either (i) refactor this or (ii) explain what this is doing with this comment?

results[qk][elem[0]].append(elem[1:])

return {
key: {a: (b[0] if len(b) == 1 else b) for a, b in value.items()}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants