Fix targets and extra build args #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sntx626
approved these changes
Oct 2, 2025
Sntx626
left a comment
Sntx626
left a comment
There was a problem hiding this comment.
Tested, fixes the problem, looks good.
LGTM
rvem
approved these changes
Dec 18, 2025
Member
|
LGTM, thanks for the contribution. |
magic0whi
added a commit
to magic0whi/nixos_configs_flake
that referenced
this pull request
Jan 22, 2026
- Update deployment instructions to use shell expansion for targets (e.g., `Proteus-NixOS-{1..6}`) and single `--targets` flag, leveraging fixes in `deploy-rs` (PR #341).
- Add `-- --show-trace --verbose` flags to the deployment example.
ref: serokell/deploy-rs#341
Signed-off-by: Proteus Qian <sudaku233@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #325 by building upon the fix (#327) from @VolodiaPG for build targets, adding a fix for extra build args.
With this, deploying to multiple hosts with build args works again, e.g.