Implement --test flag
#353
Open
+29
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-h
commented
Dec 6, 2025
| &deploy::LoggerType::Deploy, | ||
| )?; | ||
|
|
||
| if opts.dry_activate && opts.boot { |
Author
There was a problem hiding this comment.
Maybe this was intentionally not handled in clap; if so, I can revert that.
Contributor
There was a problem hiding this comment.
This seems like a good change. I prefer the solution you are taking.
Closed
Contributor
|
Could you update the |
Author
|
@weriomat Sorry, could you be more specific on what I need to update? I took a look at |
weriomat
approved these changes
Dec 9, 2025
Contributor
weriomat
left a comment
weriomat
left a comment
There was a problem hiding this comment.
Pardon me, I forgot that the interface.json is only applicable for configuration specifiable in the .#deploy output of the flake.
Author
|
cc @rvem -- is there anything else that needs to be done before this can be merged? |
cole-h
force-pushed
the
implement-test-flag
branch
from
8c9e561 to
974f1ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #250.