fix compatibility with nix 2.33+ show-derivation output #359
+13
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szlend
commented
Jan 4, 2026
|
|
||
| show_derivation_command | ||
| let show_derivation_output = Command::new("nix") | ||
| .arg("--experimental-features").arg("nix-command") |
Contributor
Author
There was a problem hiding this comment.
Not really a necessary change, but show-derivation is technically part of the nix-command experimental feature, and this is done in other places.
Also nix show-derivation has been deprecated by nix derivation show a while back, but not sure when we actually want to move to it. I left it alone for now as the old command still works.
|
Thanks! I tested this and for me this worked and solved #355 |
|
i'm also using this by default for some days and i didn't encounter any issues (and it saved my pants as i |
Contributor
Author
|
cc @rvem |
|
working well for me |
|
This PR fixed deploys for me as well. Good stuff! Before: After, deploy works fine |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken by this change: https://nix.dev/manual/nix/2.33/release-notes/rl-2.33.html#derivation-json-format-changes
Fixes #355