Treat !lava, !slime, and !tele like *lava, *slime, and *tele, respectively #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of like regular water
Owner
|
/CC @Toodles2You , @andrei-drexler , @ericwa |
Contributor
|
Looks good to me! I probably forgot about this since I tested this with the vanilla Half-Life WADs, which don't use the other liquid types. |
Contributor
|
Change looks fine. |
Owner
|
OK then, this is in. Thanks. |
Contributor
|
Also cherry-picked for vkQuake. Thanks ! |
Owner
@vsonnier: That cherry-pick looks wrong: bad parenthesing. I suggest removing the parentheses and do it like it's done here. |
Contributor
|
@sezero You are right, thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of like regular water. Fix of an oversight I noticed from #117, where
!acting like*was added.From what I can tell, this is related to controlling their alpha transparency separately from water.