[skip ci] feat: bebop solana integration progression #11399
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Solana support to BebopSwapper (quotes and rates working) - Implement fee calculation for Solana swaps - Add comprehensive logging throughout Bebop Solana flow - Store decompiled instructions in solanaTransactionMetadata - Extract compute budget params from Bebop instructions Current status: Quotes work, fees display, but broadcast has issues. Transaction requires Bebop co-signature - investigating /v3/order flow. Blocker documented in SOLANA_BLOCKER.md Implementation plan in SOLANA_IMPLEMENTATION_PLAN.md
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Document multi-signature requirement and potential /v3/order flow. Compare with CowSwap pattern for API-based execution.
- Remove presigned transaction approach - Add getUnsignedSolanaMessage and executeSolanaMessage methods - Update trade execution to sign transaction message bytes - Use Bebop /v3/order endpoint for gasless trades with co-signing - Add base-x for base58 encoding of signatures
- Update signing logic to use wallet.solanaSignMessage when available - Extract transaction.message.serialize() to get messageBytes - Sign messageBytes directly (equivalent to Bebop's signBytes) - Fallback to adapter.signTransaction for wallets without message signing - Fixes TypeScript CI error with unused messageBytes variable
- Use wallet.solanaSignRawTransaction instead of direct provider access - Proper hdwallet API for signing prebuilt Bebop transactions - Add @noble/hashes dependency to fix Vite bundling - Update to hdwallet 1.62.29-bebop-solana-msg.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stopping point after many hours of madness. Everything seems to be happy up to broadcast, which is seemingly happy both with the /send endpoint and with Phantom (which even simulates), but seeing nothing on-chain.
TODO:
Issue (if applicable)
Risk
Testing
Engineering
Operations
Screenshots (if applicable)