Add config to enable playback progress on media items #596
Conversation
| <s72-userwishlist-button data-slug="{{item.Slug}}" class="btn-wishlist"></s72-userwishlist-button> | ||
| </div> | ||
|
|
||
| {{if config("media_item_show_playback_progress") == "true"}} |
There was a problem hiding this comment.
Figured we already had two configs for media_item_... that affect how this stuff gets displayed so I may as well match that naming.
l0ud0gg
left a comment
l0ud0gg
left a comment
There was a problem hiding this comment.
LGTM. will test after merge
|
|
||
| // Playback progress bar shown on meta item and sub-items | ||
| --playback-progress-bar-height: 3px; | ||
| --playback-progress-bar-color: var(--secondary); |
There was a problem hiding this comment.
secondary color is the button hover color and usually just a ligher version of their brand colour. might make more sense to use the primary but will see how it looks in practice.
There was a problem hiding this comment.
this was what the existing core-template styles were doing (for the tv sub-item styling). Switching it to the primary accent colour might be fine though. I figured making it a variable meant it'd be much easier to customise in shared template or the theming ui if needed.
Adds
s72-playback-progressto meta items. This is intended for SVOD / content creator sites.I slightly tweaked the line-height of the availability label so that there's a little more room for the progress bar. I think it looks ok with a little more space and hopefully shouldn't cause layout issues cos it's absolute positioned anyway.
If it causes problems we could move the lineheight to a css var so that it's easier to customize it when this config is enabled?
Designs:
Edge cases/Caveats/Known issues
Config settings/Toggles required for the feature to work
media_item_show_playback_progress = trueChecklist