Skip to content
This repository was archived by the owner on Aug 14, 2024. It is now read-only.

Add attribute reader for carrier tracking url #133

Open
leobossmann wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add attribute reader for carrier tracking url #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e535202
Add attribute reader for carrier tracking url
leobossmann Jun 13, 2023
c779213
Code style changes
leobossmann Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
- Add attr_accessor for `additional_services` to class `Shipcloud::Shipment` to be able to access the additional_services attribute at the shipment object.
- Add attr_reader for `label_voucher_url` to class `Shipcloud::Shipment` to be able to read the label_voucher_url (QR Code url) attribute at the shipment object.
- Added missing `frozen_string_literal: true` magic comments to files
- Add attr_reader for `carrier_tracking_url` to class `Shipcloud::Shipment` to be able to read the carrier_tracking_url attribute at the shipment object.
Copy link
Contributor

@stphnrdmr stphnrdmr Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be moved to the Unreleased header, we'll move it to a new version header (probably 0.13.0) before the change is released.


### Changed
- Ensure compatibility with ruby 2.x and 3.x
Expand Down
3 changes: 2 additions & 1 deletion lib/shipcloud/shipment.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ class Shipment < Base
attr_accessor :from, :to, :carrier, :service, :package, :reference_number, :metadata,
:additional_services
attr_reader :id, :created_at, :carrier_tracking_no, :tracking_url, :label_url,
:packages, :price, :customs_declaration, :pickup, :label_voucher_url
:packages, :price, :customs_declaration, :pickup,
:label_voucher_url, :carrier_tracking_url
Copy link
Contributor

@stphnrdmr stphnrdmr Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a corresponding spec file at spec/shipcloud/shipment_spec.rb, could you add a spec for this new attribute?


def self.index_response_root
"#{class_name.downcase}s"
Expand Down