Skip to content
This repository was archived by the owner on Aug 14, 2024. It is now read-only.

Conversation

@depfu
Copy link
Contributor

@depfu depfu bot commented Dec 23, 2023

We've tried to upgrade a dependency and got errors running Bundler. It looks like there is a version conflict between two or more dependencies. Depfu doesn't try to solve these, as this would mean to update more than one dependency at a time.

Please take a look at the exact failure to figure out if this is something you need to work on.

The bundler error message was:

Bundler could not find compatible versions for gem "rubocop":
  In Gemfile:
    rubocop (~> 1.10.0)

    rubocop-performance (~> 1.20.0) was resolved to 1.20.0, which depends on
      rubocop (< 2.0, >= 1.48.1)

What changed?

✳️ rubocop-performance (~> 1.7.0 → ~> 1.20.0) · Repo · Changelog

Release Notes

1.20.0

New features

  • #384: Support optimized String#dup for Performance/UnfreezeString when Ruby 3.3+. (@koic)

Bug fixes

  • #374: Fix an error for Performance/MapMethodChain when using map method chain without receiver. (@koic)
  • #386: Fix a false negative for Performance/StringIdentifierArgument when using string interpolation. (@earlopain)
  • #419: Make Performance/Count, Performance/FixedSize, Performance/FlatMap, Performance/InefficientHashSearch, Performance/RangeInclude, Performance/RedundantSortBlock, Performance/ReverseFirst, Performance/SelectMap, Performance/Size, Performance/SortReverse, and Performance/TimesMap cops aware of safe navigation operator. (@koic)
  • #390: Fix a false negative for Performance/ReverseEach when safe navigation is between reverse and each. (@fatkodima)
  • #401: Make Performance/Sum aware of safe navigation operator. (@koic)

Changes

  • #389: Improve Performance/MapCompact to handle more safe navigation calls. (@fatkodima)
  • #395: Enhance Performance/StringInclude to handle === method. (@fatkodima)
  • #388: Require RuboCop 1.30+ as runtime dependency. (@koic)
  • #380: Require RuboCop AST 1.30.0+. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 35 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu
Copy link
Contributor Author

depfu bot commented Jan 1, 2024

Closed in favor of #145.

@depfu depfu bot closed this Jan 1, 2024
@depfu depfu bot deleted the depfu/update/rubocop-performance-1.20.0 branch January 1, 2024 01:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant