This repository was archived by the owner on Aug 14, 2024. It is now read-only.
Upgrade rubocop-performance to version 1.12.0 #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop-performance (~> 1.7.0 → ~> 1.12.0) · Repo · Changelog
Release Notes
1.12.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 28 commits:
Cut 1.12.0Update ChangelogMerge pull request #267 from koic/add_new_performance_concurrent_monotonic_time_copAdd new `Performance/ConcurrentMonotonicTime` copAdd project_spec test to ensure that Safe: true is not given in a config, since it is redundantMerge pull request #263 from koic/change_unmark_autocorrect_false_from_performance_string_includeFix an error when running `rake new_cop`Merge pull request #266 from koic/false_negative_for_performance_redundant_block_callMerge pull request #262 from koic/add_safety_section_to_docs[Fix #261] Fix a false negative for `Performance/RedundantBlockCall`Tweak specs for `Performance/RedundantBlockCall`CI against JRuby 9.3Merge pull request #265 from mvz/fix-changelog-tasksMake changelog tasks emit correct URL templateMerge pull request #264 from mvz/fix-sum-copFix error in Performance/Sum when method has no bracketsRemove an unnecessary parameter for spell checking GH Action workflowAdd `Safety` section to documentationUnmark `AutoCorrect: false` from `Performance/StringInclude`Tweak spell checking GitHub Actions workflow nameEnable `Lint/BooleanSymbol` copMerge pull request #260 from koic/add_spell_checking_workflowAdd spell checking GitHub Actions workflowTweak the docsUse `expect_no_corrections` for test code that is not auto-correctedFix a build errorRemove redundant `TargetRubyVersion`Switch back docs version to masterDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands