SG-40980 WIP #100
SG-40980 WIP #100
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Azure Pipelines configuration to replace the existing build pipeline with a code style validation pipeline. The changes remove the dependency on shared CI tools and implement a standalone pre-commit validation workflow.
Key Changes
- Removed the tk-ci-tools repository reference and associated variable group
- Created a new code-style-validation.yml job that runs pre-commit hooks
- Updated the main pipeline to use the new code style validation template
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| azure_pipelines/code-style-validation.yml | New pipeline job that installs and runs pre-commit for code style validation |
| azure_pipelines.yml | Removed tk-ci-tools integration and replaced build pipeline with code style validation template |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| displayName: Validate code | ||
| inputs: | ||
| targetType: inline | ||
| script: pre-commit run --all |
There was a problem hiding this comment.
The pre-commit command is missing the '--files' flag. The correct command should be 'pre-commit run --all-files' to validate all files in the repository.
| script: pre-commit run --all | |
| script: pre-commit run --all-files |
azure_pipelines.yml
Outdated
| - template: build-pipeline.yml@templates | ||
| parameters: | ||
| has_unit_tests: false | ||
| - template: code-style-validation.yml |
There was a problem hiding this comment.
The template path is missing the 'azure_pipelines/' directory prefix. It should be 'azure_pipelines/code-style-validation.yml' to correctly reference the new template file.
| - template: code-style-validation.yml | |
| - template: azure_pipelines/code-style-validation.yml |
No description provided.