SG-40980 Simplify Azure Pipeline CI pipeline #70
Conversation
…plify-ci-pipeline
There was a problem hiding this comment.
Pull request overview
This PR refactors the Azure Pipeline CI configuration to simplify test execution across multiple OS and Python version combinations. The changes replace a repetitive, manually-defined job structure with a more maintainable loop-based approach using Azure DevOps' each operator.
Key Changes:
- Introduced parameterized VFX Reference Platform versions (CY2022-2024) with associated Python and Qt wrapper configurations
- Consolidated OS version definitions into a single parameter with VM image mappings
- Replaced 9 individual job template invocations with nested loops that dynamically generate test jobs
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/run-tests.yml | Refactored from explicit job definitions to parameterized loops using VFX platform and OS version parameters |
| internal/run-tests-with.yml | Updated default parameter values and simplified job display name to accommodate dynamic generation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| image_name: "" | ||
| # Name of the Qt wrapper to pip install. Should be PySide or PySide2 | ||
| qt_wrapper: PySide2==5.15.2.1 | ||
| qt_wrapper: '' |
There was a problem hiding this comment.
Changing the default value from 'PySide2==5.15.2.1' to an empty string could break existing callers that don't explicitly pass qt_wrapper. Consider keeping the original default or documenting that this parameter is now required.
There was a problem hiding this comment.
Invalid. I control who calls internal/run-tests-with.yml. It's only in this repository.
| qt_wrapper: '' | ||
| # Python version to use. | ||
| python_version: 3.7 | ||
| python_version: '' |
There was a problem hiding this comment.
Changing the default value from '3.7' to an empty string could break existing callers that don't explicitly pass python_version. Consider keeping the original default or documenting that this parameter is now required.
There was a problem hiding this comment.
Invalid. I control who calls internal/run-tests-with.yml. It's only in this repository.
Simplify the os_version/python_version combination for calling the test template.
No longer use a matrix strategy because only work with one dimension.
Define and use parameter for each version dimension and use the each operator for looping over both parameters.
Replicated changes on multiple repositories