-
Notifications
You must be signed in to change notification settings - Fork 120
SG-41529 prevent config autoupdate #1076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eduardoChaucaGallegos
wants to merge
14
commits into
master
Choose a base branch
from
ticket/SG-40996-prevent-config-autoupdate
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SG-41529 prevent config autoupdate #1076
eduardoChaucaGallegos
wants to merge
14
commits into
master
from
ticket/SG-40996-prevent-config-autoupdate
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et/SG-40996-prevent-config-autoupdate
…m:shotgunsoftware/tk-core into ticket/SG-40996-prevent-config-autoupdate
Contributor
carlos-villavicencio-adsk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some small code style suggestions, but overall looks good. I didn't reviewed the logic because I don't fully understand the goal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces robust Python version compatibility checks for bundle auto-updates and tag selection in the descriptor system, focusing on git tag descriptors. It ensures that the latest available bundle version is compatible with the running Python interpreter, and gracefully falls back to the highest compatible local or cached version when necessary. The changes also improve error handling and logging for version parsing and compatibility checks.
Python version compatibility enforcement:
_check_minimum_python_versiontobase.pyto verify if the current Python version meets the minimum required version specified in the bundle manifest. This is now used throughout the descriptor logic.git_tag.py, the_get_latest_versionmethod now checks if the latest tag is compatible with the current Python version, and if not, attempts to find the highest compatible version from the local repository or bundle cache, logging warnings when auto-update is blocked.Local and cached version fallback logic:
_get_local_repository_tag,_check_local_tag_compatibility, and_find_compatible_cached_versioningit_tag.pyto support falling back to a compatible local tag or cached version if the latest tag is incompatible.Error handling and logging improvements:
_find_latest_tag_by_patterninbase.pyto skip malformed version tags and log debug messages.General codebase cleanup:
base.pyandgit_tag.py. [1] [2]dict_from_uri.These changes collectively ensure that bundle updates are safe and compatible with the user's Python environment, preventing runtime errors due to version mismatches and providing clear feedback when auto-updates are blocked.