Skip to content

Conversation

@spliffone
Copy link
Member

@spliffone spliffone commented Jan 21, 2026

…rtical-header

Describe in detail what your merge request does and why. Add relevant
screenshots and reference related issues via Closes #XY or Related to #XY.


@spliffone spliffone requested a review from a team as a code owner January 21, 2026 13:59
Copy link
Member

@spike-rabbit spike-rabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check whether it might be easier to just use animate.enter / leave instead of always having those elements in the DOM?

@spliffone spliffone force-pushed the refactor/vertical-vabar-header-use-css-transition branch from a19beeb to 6c3d17c Compare January 21, 2026 15:33
@github-actions
Copy link

@spliffone spliffone force-pushed the refactor/vertical-vabar-header-use-css-transition branch 3 times, most recently from 7b8a735 to 7a6798f Compare January 24, 2026 16:28
@spliffone
Copy link
Member Author

Did you check whether it might be easier to just use animate.enter / leave instead of always having those elements in the DOM?

@spike-rabbit we use now animate.leave like you proposed

Comment on lines +35 to +40
constructor() {
afterNextRender(() => {
// Only enable transitions after the first render to avoid unwanted animations on load
this.initialized.set(true);
});
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can simplify this by adding an enter animation on the host element an then something like this in the style sheets.

:host.component-enter .inline-group {
  // Prevents initial animation on component load
  transition: none;
}

Then we have less custom JS logic. See the navbar group for an example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying the same thing but Angular doesn't drop the 'animate.enter' class from the DOM. When I bind it to the host:

host: {
    'animate.enter': 'component-enter',
    ...

I assume it is cause by the existing transition on the host element. I guess Angular internally listen to the animationend and gets somehow confused.

@github-actions
Copy link

Code Coverage

@spliffone spliffone force-pushed the refactor/vertical-vabar-header-use-css-transition branch from 734b68c to 2ba567d Compare January 26, 2026 13:50
@dauriamarco
Copy link
Member

As already discussed with @spliffone, I’m closing this in favor of #1226, where the full animations refactoring will be handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants