feat(icons): use open source icons

[spike-rabbit]

Describe in detail what your merge request does and why. Add relevant
screenshots and reference related issues via Closes #XY or Related to #XY.

---

• I confirm that this MR follows the contribution guidelines.

[gemini-code-assist]

Summary of Changes

Hello @spike-rabbit, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the project's icon management by integrating the new @siemens/element-icons open-source library. This change streamlines icon usage, removes a large amount of custom SVG code, and introduces a more consistent approach to icon sizing and positioning throughout the UI, ensuring better maintainability and alignment with design standards.

Highlights

• Icon Library Migration: The project has migrated from a custom icon set to the new @siemens/element-icons open-source library, replacing numerous inline SVG definitions with a more streamlined import.
• Icon Sizing and Spacing Refinement: CSS styles across various components have been updated to standardize icon sizing and spacing. This includes the introduction of a new icon-large class and adjustments to margin-block and margin-inline properties for better consistency.
• Dependency Update: The package.json file now includes the @siemens/element-icons dependency, reflecting the adoption of the new open-source icon library.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a significant improvement by migrating the icon library from an internal @simpl package to the open-source @siemens/element-icons package. This change enhances maintainability and aligns with open-source best practices. Additionally, several CSS files have been refactored to remove negative margins and simplify calc() expressions for margin properties, which improves layout predictability and code readability. The icon sizing variables have also been refined to offer better control over icon presentation. Overall, these changes contribute positively to the project's maintainability and consistency.

[github-actions]

Documentation.
Examples.
Playwright report.

Coverage Reports:

• element-ng
• element-translate-ng

[panch1739]

@spike-rabbit We had a look with @hbxes and we found some issues. I will list them here, please reach out if things are not clear.

• Badges: Add 2px spacing between icon and label
• Button group, icon only version: width should be set to 32px. Right now is 29px.
• Split button, icon only version: Width should be 32px. Right now is 28px.
• Data table, status column: add spacing between icons of 16px
• Data table header: add 2px spacing between sort icon and label
• Application header, launchpad button: Width should be 48px. Right now is 40px
• Breadcrumb: arrow should be 16px. Right now is 24px
• Circle status: status icon should be 20px. Right now is 24px
• Color picker: Open the menu. Selected swatch icon is misaligned.
• [Layout panel example](https://d33c9dcnqinn2a.cloudfront.net/pr-1353/pages/e [ ] ement-examples/#/overview/si-electron-titlebar/si-fixed-height-layout-side-panel?q=layout): [ ] exchange icons for selection button
• File uploader: Upload a file. Document icon is missaligned in relation to the text. Icon s [ ] ould be 24px
• Help button should be 16px, including in inputs
• si-dynamic-form-fields: link icon should be 20px
• Inline notification: The icon and text is misaligned. Remove the mt-1 from text and center e [ ] erything in the body of the notification.
• Search bar: icon is misaligned. Size should be 20px
• Is-modal-dialog: change icon in header to 24px
• Nav bar vertica: in collapsed state, the search bar is not centered
• Notification item: Miss aligned status and unread icon. Status icon should be 20px.
• Result list: misaligned, icon size 20px
• Side panel collapsible, dot missalinged
• Sort bar: add spacing of 2px between sort icon and label
• Tree view: all icons 20px
• Wizard: icons for steps should be 24px
• Wizard number steps: alignment broken
• Wizard vertical: check line alignment

[panch1739]

@spike-rabbit I found just some small things:

• Avatar: The status icon should be 20px.
• File uploader: File icon should be aligned with text
• CAB: Spacing between icon and label should be 4px
• Notification item: Status icon should be aligned with the Title and not the timestamp

Let me know and we can review them together :) @hbxes can you check also?

[spike-rabbit]

@panch1739 fixed, except for file-uploader. This was broken before and requires more adjustment.

[github-actions]

[panch1739]

@panch1739 fixed, except for file-uploader. This was broken before and requires more adjustment.

@spike-rabbit ah perfect, that is ok then