Skip to content

Conversation

@spliffone
Copy link
Member

@spliffone spliffone commented Jan 27, 2026

Describe in detail what your merge request does and why. Add relevant
screenshots and reference related issues via Closes #XY or Related to #XY.


@spliffone spliffone requested a review from a team as a code owner January 27, 2026 13:13
@spliffone spliffone marked this pull request as draft January 27, 2026 13:13
@gemini-code-assist
Copy link

Summary of Changes

Hello @spliffone, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant modernization of the project's testing infrastructure by transitioning from the Karma/Jasmine setup to Vitest. The changes span across configuration files, dependency management, and the actual test code, ensuring that the unit tests are fully compatible with the new, faster, and more developer-friendly Vitest environment. This move aims to streamline the testing process and enhance overall development efficiency.

Highlights

  • Testing Framework Migration: The unit testing framework for the element-translate-ng project has been migrated from Karma and Jasmine to Vitest.
  • Angular Configuration Update: The angular.json file has been updated to use the new @angular/build:unit-test builder, pointing to a vitest.config.ts file, and includes new ci and development configurations for testing.
  • Dependency Changes: New development dependencies such as vitest, @vitest/browser-playwright, and jsdom have been introduced to support the Vitest testing environment.
  • Test File Refactoring: Existing test files have been refactored to align with Vitest's testing patterns, specifically by using async/await with firstValueFrom for RxJS observables and vi.spyOn for mocking.
  • Configuration Cleanup and Adjustment: The karma.conf.cjs file has been removed, and TypeScript configurations (tsconfig.lib.json, tsconfig.spec.json) have been adjusted to properly support Vitest and manage mock files.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully migrates the testing framework for element-translate-ng from Karma/Jasmine to Vitest. The changes are well-executed, including updates to angular.json to use the new test runner, modifications to package.json with the necessary dependencies, and refactoring of test files to use Vitest's API and modern async/await syntax. The removal of the Karma configuration and updates to tsconfig files are also correctly handled. I have one minor suggestion for improving the clarity of the new vitest.config.ts file.

@spliffone spliffone force-pushed the build/migrate-translate-to-vitest branch from 4360f3f to 2cfb145 Compare January 27, 2026 13:30
@spliffone spliffone force-pushed the build/migrate-translate-to-vitest branch from 2cfb145 to 3ecb214 Compare January 27, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants