-
Notifications
You must be signed in to change notification settings - Fork 13
feat: update siemens sand colors #1386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @timowolf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating core branding dependencies to incorporate the latest design specifications. By upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the @simpl/brand dependency from version 2.3.0 to 3.1.0, which appears to be for updating the Siemens sand colors. An npm override is also added for @siemens/element-theme. My feedback includes a suggestion to make this override more robust by using the workspace:* protocol, which is a best practice for monorepos. It would also be helpful to add details about this major dependency upgrade to the pull request description.
| "typescript": "$typescript" | ||
| }, | ||
| "@simpl/brand": { | ||
| "@siemens/element-theme": ">1.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version range ">1.0.0" for @siemens/element-theme is very broad. To ensure that @simpl/brand always uses the version of @siemens/element-theme from this monorepo workspace, it's better to use the workspace:* protocol. This will make the dependency resolution more robust and prevent potential issues if the version of @siemens/element-theme changes significantly.
| "@siemens/element-theme": ">1.0.0" | |
| "@siemens/element-theme": "workspace:*" |
|
Documentation. Coverage Reports: |
16ff88d to
bcc0fcd
Compare
Updating to new sand colors.