refactor(form): sort validation error keys

[spliffone]

Describe in detail what your merge request does and why. Add relevant
screenshots and reference related issues via Closes #XY or Related to #XY.

---

• I confirm that this MR follows the contribution guidelines.

[gemini-code-assist]

Summary of Changes

Hello @spliffone, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a minor refactoring within the form validation service. The primary goal is to enhance code consistency and maintainability by alphabetically sorting the keys that define default validation error messages. This change does not alter the functionality of the validation system but makes the configuration easier to navigate and understand for developers.

Highlights

• Refactoring: The validation error keys within the buildDefaults function in si-form-validation-error.service.ts have been reordered.
• Code Readability: The reordering ensures that the validation error keys are now sorted alphabetically, improving the readability and maintainability of the code.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a nice refactoring that sorts the validation error keys alphabetically in buildDefaults. This improves code readability and maintainability. The change is correct and I have no further suggestions. Well done!

[github-actions]

Documentation.
Examples.
Playwright report.

Coverage Reports:

• element-ng
• element-translate-ng

[dr-itz]

hmm..not sure I like it. Reason: min*/max* that are similar are now no longer next to each other, decreasing maintainability IMO

[spliffone]

hmm..not sure I like it. Reason: min*/max* that are similar are now no longer next to each other, decreasing maintainability IMO

At the moment we have a random order of keys which is also unmaintainable e.g. adding a new key can be anywhere with an ascending order we can simply sort it and it is predictable. The message should be anyway reviewed by UX so I don't think it is really a matter of maintenance. Maybe we should hear other voices...

[dr-itz]

I really think this should be always grouped by concern, i.e. everything related to numbers is one group, another is string, another is date. When grouped, I don't actually mind alphabetical ordering inside a group, even prefer it.

[github-actions]