test: remove usage of done function part 2

[spliffone]

Describe in detail what your merge request does and why. Add relevant
screenshots and reference related issues via Closes #XY or Related to #XY.

---

• I confirm that this MR follows the contribution guidelines.

[gemini-code-assist]

Summary of Changes

Hello @spliffone, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing the asynchronous testing patterns within the codebase. It systematically migrates existing tests that relied on the done: DoneFn callback mechanism to the more readable and efficient async/await syntax, wrapped with Promises. This refactoring improves the clarity and maintainability of the test suite by adopting a more contemporary approach to handling asynchronous operations in JavaScript.

Highlights

• Asynchronous Test Modernization: Refactored numerous asynchronous tests across various component and service spec files to utilize the modern async/await syntax.
• Removal of DoneFn Callback: Replaced the traditional done: DoneFn callback pattern with Promise wrappers and await expressions, enhancing test readability and maintainability.
• Improved Test Clarity: The changes lead to a more sequential and understandable flow for asynchronous operations within the tests, aligning with contemporary JavaScript testing practices.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly replaces the Jasmine done function with async/await for handling asynchronous tests. This is a great improvement for test readability and reliability. I've noticed a recurring pattern of using new Promise with a counter to wait for observables. While this works, it can be further simplified by using RxJS operators like firstValueFrom, zip, take, and toArray. I've added specific suggestions to refactor these tests to be more concise and idiomatic with RxJS.

[github-actions]

Documentation.
Examples.
Playwright report.

Coverage Reports:

• element-ng
• element-translate-ng

[github-actions]