-
Notifications
You must be signed in to change notification settings - Fork 13
Refactor/improve form item usage in examples #1391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
akashsonune
commented
Jan 28, 2026
- I confirm that this MR follows the contribution guidelines.
Summary of ChangesHello @akashsonune, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant refactoring of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the si-form-item component to make its label property required, which is a good step towards better accessibility and component API clarity. It also makes errormessageId required on the SiFormItemControl interface. The changes across the codebase correctly adapt to these new requirements.
I've left a couple of suggestions in src/app/examples/si-application-header/si-launchpad.html where the si-form-item usage could be further improved by following the excellent refactoring pattern you've already applied in src/app/examples/si-localization/si-localization.html. Instead of using an empty label as a workaround, moving the existing label text to the si-form-item would be more idiomatic and better for accessibility. Additionally, removing the id attribute from input elements within si-form-item is recommended as it is automatically generated.
4318d97 to
cb824e8
Compare
|
Documentation. Coverage Reports: |
51c2d84 to
1924b5f
Compare
cf0bbce to
543e63a
Compare
0cdbe61 to
d08059d
Compare
4d5235f to
84fe005
Compare
84fe005 to
42fe8b3
Compare
da54afa to
68172a9
Compare
68172a9 to
caec0c8
Compare
|
@spike-rabbit can you check now |