-
-
Notifications
You must be signed in to change notification settings - Fork 5
Bigger mobile stuff, responsive filter options, moved burger btn #2127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThis PR refactors frontend UI components by simplifying sidebar trigger usage patterns, introducing responsive height adjustments using Tailwind's Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@frontend/viewer/src/project/browse/SearchFilter.svelte`:
- Around line 109-110: The Sidebar.Trigger currently uses only "aspect-square
p-0" which may not guarantee a usable touch target; update the Sidebar.Trigger
element (the one with icon="i-mdi-menu") to include explicit sizing classes
(e.g., set width/height such as w-10 or w-12 and matching h-10/h-12 and
comfortable padding like p-2) so the rendered button meets touch-target
guidelines, and verify it visually and via mobile touch emulation; keep
ComposableInput sizing (class="px-1 ... h-12") unchanged unless layout shifts
require adjusting neighboring spacing.
🧹 Nitpick comments (1)
frontend/viewer/src/project/browse/SearchFilter.svelte (1)
109-128: Prefer icons imported from$lib/icons/.Both the menu and filter icons are referenced via string IDs. The guideline here is to import icons from
$lib/icons/for icon components to keep the icon pipeline consistent. As per coding guidelines, please switch to icon imports from$lib/icons/.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Several overlapping adjustments:
Before:

After:

Before:

After - mobile:

After - desktop:

Before:

After:
