-
-
Notifications
You must be signed in to change notification settings - Fork 5
Full virtual scrolling for entry list #2129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
myieye
wants to merge
42
commits into
develop
Choose a base branch
from
feature/virtual-scrolling-entries
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
8e82fe8
Do morph type filtering server-side
myieye 22859d2
temp
myieye c19b768
Add Delayed component to wrap VList items
myieye 8ea5a96
Move SortMenu and extract options
myieye 486cb63
Temp virtual scrolling entry loader plan
myieye 512faf2
Add entry loader service
myieye a24be28
Use entry loader service in entries-list
myieye b0154ce
Make agent instructions leaner
myieye a4ec425
Add virtual scrolling tests
myieye 61524df
AI feedback
myieye ca3f582
Remove old service
myieye 85b76c5
Add entry-loader-service tests
myieye 7fc9515
Prepare backend API for querying entry index
myieye 8e27a54
v2 test improvements with added event handling
myieye baa5843
Add more failing event handling test cases
myieye 0daa812
Frontend: Add entry index lookup, versions and invalidation
myieye dcf2852
Format
myieye e11c9e0
Tweak demo api
myieye 050fdec
Refactor
myieye 0b5c073
Flesh out entry-loader-service tests
myieye 330aeaa
Simplify entry-loader by making api required
myieye d1e99a6
Use quiet reset for all events
myieye 949312c
Debounce quiet resets
myieye d32d44f
Fix sqlite contains function not always registered
myieye 8ddd1d4
Handle restoring deleted entries
myieye 41461b0
Fix stale results and flicker
myieye 0e6b7e7
Fix gitignore
myieye 93bcb80
Fix and extend e2e coverage
myieye ab606b3
Fix tracking selected entry
myieye 7369263
Finish types and backend
myieye 2f969cb
Fix scroll flag
myieye ee00c87
Fix tests
myieye 9ecc968
Remove entry version tracking - generation is enough
myieye cfcdbbd
Basic update event optimizations
myieye b0417a4
Optimize and test GetEntryIndex
myieye 490046b
AI feedback
myieye 32d497d
Fix linting errors: floating promises and unused variables
myieye c1efd87
Extract i18n strings: Filter, This was deleted
myieye 20937c0
PR feedback
myieye 0f45998
Fix boolean logic error
myieye 06a2534
i18n:extract and ai enhance
myieye 340f407
fix(viewer): stabilize project view snapshots by waiting for rows
myieye File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
backend/FwLite/FwDataMiniLcmBridge.Tests/MiniLcmTests/EntryIndexTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| using FwDataMiniLcmBridge.Tests.Fixtures; | ||
|
|
||
| namespace FwDataMiniLcmBridge.Tests.MiniLcmTests; | ||
|
|
||
| [Collection(ProjectLoaderFixture.Name)] | ||
| public class EntryIndexTests(ProjectLoaderFixture fixture) : EntryIndexTestsBase | ||
| { | ||
| protected override Task<IMiniLcmApi> NewApi() | ||
| { | ||
| return Task.FromResult<IMiniLcmApi>(fixture.NewProjectApi("entry-index-test", "en", "en")); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
backend/FwLite/LcmCrdt.Tests/MiniLcmTests/EntryIndexTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| using Xunit.Abstractions; | ||
|
|
||
| namespace LcmCrdt.Tests.MiniLcmTests; | ||
|
|
||
| public class EntryIndexTests(ITestOutputHelper output) : EntryIndexTestsBase | ||
| { | ||
| private readonly MiniLcmApiFixture _fixture = new(); | ||
|
|
||
| public override async Task InitializeAsync() | ||
| { | ||
| _fixture.LogTo(output); | ||
| await _fixture.InitializeAsync(); | ||
| await base.InitializeAsync(); | ||
| } | ||
|
|
||
| protected override Task<IMiniLcmApi> NewApi() | ||
| { | ||
| return Task.FromResult<IMiniLcmApi>(_fixture.Api); | ||
| } | ||
|
|
||
| public override async Task DisposeAsync() | ||
| { | ||
| await base.DisposeAsync(); | ||
| await _fixture.DisposeAsync(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.