.NET Framework 4.8 upgrade #255
Conversation
* Add Windows GitHub Actions workflow - build-test-installer-release * Versioning is now handled via latest tag * Publish test results in the PR * rename SkipOnTeamCity to SkipOnCI
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the .NET Framework target version from 4.6.2 (and 4.0 for AutoSegmenter) to 4.8.1 across the SayMore solution.
- Updated TargetFrameworkVersion in all project files to v4.8.1
- Updated supportedRuntime configurations in app.config files
- Removed TargetFrameworkProfile constraints (specifically the "Client" profile from AutoSegmenter)
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/SayMoreTests/app.config | Updated runtime configuration to target .NET Framework 4.8.1 |
| src/SayMoreTests/SayMoreTests.csproj | Updated project target framework to v4.8.1 |
| src/SayMore/app.config | Updated runtime configuration to target .NET Framework 4.8.1 |
| src/SayMore/SayMore.csproj | Updated project target framework to v4.8.1 |
| src/AutoSegmenter/AutoSegmenter.csproj | Updated from v4.0 Client Profile to v4.8.1 with empty profile |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
You might have missed my comment in #248. I am trying to target 4.8. It seemed like 4.8.1 didn't offer a whole lot that would be super relevant to SayMore and it cuts out support for some older versions of the OS. Even though we don't generally prioritize support for unsupported OS versions, I at least want to try to get a 64-bit version of SayMore released that would run on those older systems. |
|
I'm not opposed to you doing this as a separate PR (my work is getting hung up on a couple things related to 64-bit, I think), but if there's not a compelling reason to go all the way to 4.8.1, could you change this to target 4.8 instead? |
|
You're right. 4.8.0 is pretty much just as good as 4.8.1, but without arm64 support. After 4.8.0 and sdk-style csproj and 64-bit, I think we can move on to dual target 4.8.1 and net90-windows. We can get other broad support there, including arm64 |
megahirt
force-pushed
the
saymore-net481-upgrade
branch
from
5931aad to
51bcd54
Compare
|
closing in favor of #257 |
Summary
Testing
SayMore builds and all CI tests are passing. Once merged, this will generate a signed installer for manual testing.
This change is