Henry/optical flow #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Please create def test_optical_flow():
# assert the expected values match the actual values output from the OpticalFlow class
|
tall-josh
reviewed
May 13, 2025
neuflowv2/optical_flow.py
Outdated
| # Store current frame for next comparison | ||
| self.prev_frame = frame_tensor | ||
|
|
||
| return movement_score |
Collaborator
There was a problem hiding this comment.
Please:
- rename
flowtoflow_vectors - have
updatereturnflow_vectorsnotmovement_score - make another function
def compute_movement_score(self, flow) -> float:
…ement_score to cal movement score
…The first frame will be no movement score so need to handle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optical Flow class with test by video