Merging Furthest Upstream Content #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the acknowledgement functionality from the socket.io spec
Make the flashsocket be able to support https connections
….as use decodeURIComponent() instead of unescape() to support multibyte data (like chinese.).
use decodeURIComponent() instead of unescape() to support multibyte data
…step to being Pure AS3
…e for other developers
…is received from server we check what endpoint we are connected against and if it is different to the one requested we make the switch, Connect event is only firec after connecting to the correct endpoint
…he 4th part containing the data could also contain ':' - FIXED
adds all important clone method to FlashSocketEvent.as
…ger. Added method getConnectionUrl with intention of allowing FlashSocket to be extended.
here was no polling implementation anyway, only a single initial request, it wasn't possible to receive messages before upgrading to WebSocket. Apart from the extra roundtrip, this had the undesired side-effect that the server thought we are already connected, while the client only considered itself connected after the upgrade. So we removed the polling request completely, and only connect via WebSocket (direct connect, not upgrade).
- replace CLOSE event by DISCONNECT - add destroy() method - bugfix: ensure heartbeat is stopped when socket closes - bugfix: dispatch DISCONNECT on manual close()
If the first transport fails while connecting, try the next one. This allows to use polling only if websocket fails (which is different than connecting with polling and uprgading later).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just realized a lot has happened in the development of this project since I stopped watching flash. It appears many improvements have been made and I'd like to make sure people who end up here see those and can benefit from them.