Skip to content

Conversation

@dpole
Copy link
Contributor

@dpole dpole commented Apr 15, 2020

I think that the following eval function for PowerSpectrumFromFile has two bugs

return amp * self._cl[..., ell] / self._cl[..., ell_0, np.newaxis]

  1. It adds a new axis to the evaluation at ell = ell_0 for unclear reasons
  2. It doesn't rise errors when ell_0 == None, the unintended result is the addition of an extra axis to the template Cl (in addition to the axis added at the previous point)

I propose to remove ell_0 and use the amp argument

@dpole
Copy link
Contributor Author

dpole commented Apr 15, 2020

@xzackli , these changes possibly affect some of your case-of-use. Can you review them and, in case you agree, fix the ACT tests accordingly?

@dpole dpole requested a review from xzackli May 19, 2020 06:35
@xzackli xzackli self-assigned this May 20, 2020
@dpole
Copy link
Contributor Author

dpole commented Nov 6, 2020

I think this PR should be closed. @xzackli , as I said in my last comment, I believe it would be better if you could give it a look before we merge: some of your tests/applications may be affected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants